Skip to content

Authoritative mount setup #57370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
icewind1991 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Authoritative mount setup #57370

icewind1991 wants to merge 1 commit into from
+41 −20

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Jan 6, 2026 •
edited
Loading

When the "requires non-cached filesystem setup" logic is hit when setting up for a path, just reload the non-authoritative mount providers instead of doing the full setup.

@icewind1991 icewind1991 added this to the Nextcloud 33 milestone Jan 6, 2026
@icewind1991 icewind1991 added the 2. developing Work in progress label Jan 6, 2026
@icewind1991 icewind1991 force-pushed the authoritative-mount-setup branch 4 times, most recently from c0b38cb to 91a842d Compare January 12, 2026 17:01
@icewind1991 icewind1991 force-pushed the authoritative-mount-setup branch from 91a842d to 467487e Compare January 13, 2026 15:42
@icewind1991 icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 13, 2026
@icewind1991 icewind1991 marked this pull request as ready for review January 13, 2026 15:43
@icewind1991 icewind1991 requested a review from a team as a code owner January 13, 2026 15:43
@icewind1991 icewind1991 requested review from Altahrim, ArtificialOwl, leftybournes and sorbaugh and removed request for a team January 13, 2026 15:43
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 12, 2026
Merged
@artonge
Copy link
Contributor

artonge commented Jan 13, 2026

Should we feature-gate that as well?

@icewind1991
Copy link
Member Author

icewind1991 commented Jan 13, 2026

Looks like a test is running into an infinite loop...

@icewind1991
Copy link
Member Author

icewind1991 commented Jan 13, 2026 •
edited
Loading

Right, without #57493 setting up the share mounts involves more filesystem access.

Lets see if all open PRs together result in a workable whole: #57528

@icewind1991 icewind1991 mentioned this pull request Jan 13, 2026
Draft
3 tasks
@icewind1991
Copy link
Member Author

icewind1991 commented Jan 14, 2026

Lets see if all open PRs together result in a workable whole: #57528

It solves the loop at least

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991 @artonge @CarlSchwan