debt(files_sharing): Unify getSharedWithByPath and getSharedWith
#57552
+45
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
requested review from
Altahrim,
CarlSchwan,
salmart-dev and
yemkareems
and removed request for
a team
artonge
added
3. to review
artonge
force-pushed
the
artonge/debt/files_sharing_unify_methods
branch
from
0b251f6 to
99cc26d
Compare
artonge
force-pushed
the
feature/54562/files-sharing-authoritative
branch
4 times, most recently
from
55ae98c to
e278f3e
Compare
artonge
force-pushed
the
artonge/debt/files_sharing_unify_methods
branch
from
99cc26d to
31110cb
Compare
artonge
changed the base branch from
feature/54562/files-sharing-authoritative
to
master
artonge
force-pushed
the
artonge/debt/files_sharing_unify_methods
branch
2 times, most recently
from
8d2157b to
4695508
Compare
Follow-up of #57285 This ensure that the behavior is the same and reduce code duplication. Salvatore's version seems to be more optimized, but I prefer those change to be done separately and for both methods. Signed-off-by: Louis Chmn <[email protected]>
artonge
force-pushed
the
artonge/debt/files_sharing_unify_methods
branch
from
4695508 to
bba8e90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #57285
This ensure that the behavior is the same and reduce code duplication.
Salvatore's version seems to be more optimized, but I prefer those change to be done separately and for both methods.