Skip to content

fix(files_sharing): Fix BeforeZipCreatedListener path handling #57573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 3 commits into from
Jan 20, 2026
Merged

fix(files_sharing): Fix BeforeZipCreatedListener path handling #57573

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e693b5
fix(files_sharing): Fix BeforeZipCreatedListener path handling
come-nc Jan 15, 2026
460d637
fix(files_sharing): Switch back event path to be relative to user folder
come-nc Jan 19, 2026
0720e26
chore: fix or suppress psalm errors for BeforeZipCreatedEvent
come-nc Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions apps/files_sharing/lib/Listener/BeforeZipCreatedListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,20 @@ public function handle(Event $event): void {
$dir = $event->getDirectory();
$files = $event->getFiles();

$pathsToCheck = [];
foreach ($files as $file) {
$pathsToCheck[] = $dir . '/' . $file;
if (empty($files)) {
$pathsToCheck = [$dir];
} else {
$pathsToCheck = [];
foreach ($files as $file) {
$pathsToCheck[] = $dir . '/' . $file;
}
}

// Check only for user/group shares. Don't restrict e.g. share links
$user = $this->userSession->getUser();
if ($user) {
$viewOnlyHandler = new ViewOnly(
$this->rootFolder->getUserFolder($user->getUID())
$this->rootFolder
);
if (!$viewOnlyHandler->check($pathsToCheck)) {
$event->setErrorMessage('Access to this resource or one of its sub-items has been denied.');
Expand Down
Loading