fix(core): accept deprecated IANA timezone aliases - #63752
Merged
Conversation
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
requested review from
Altahrim and
icewind1991
and removed request for
a team
August 28, 2026 08:21
pringelmann
added
the
feature: profile
Contributor
Author
|
/backport to stable35 |
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
artonge
approved these changes
Aug 28, 2026
Contributor
Author
|
fixing tests: they work locally, but CI runner OS does not have legacy tzdata |
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
cristianscheid
approved these changes
Aug 28, 2026
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where legacy timezone identifiers sent by browsers get silently rejected.
PHP's
listIdentifiers()defaults toALL, which skips the tz database's backward links. So many older but valid names get refused,Europe/Kievamong them, even though PHP itself resolves them without complaint. Many browsers still send the old names.Two places got this wrong:
SetUserTimezoneCommandquietly drops the value at loginBoth use ALL_WITH_BC now. Read requests already accepted these names, so this fixes write request cases.
Checklist
3. to review, feature component)stable32)AI (if applicable)