Skip to content

fix(objectstore): do not warn when ensuring the storage root exists #63889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jo23sh wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −1
Open

fix(objectstore): do not warn when ensuring the storage root exists #63889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/private/Files/ObjectStore/ObjectStoreStorage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,13 @@ public function __construct(array $parameters) {
public function mkdir(string $path, bool $force = false, array $metadata = []): bool {
$path = $this->normalizePath($path);
if (!$force && $this->file_exists($path)) {
$this->logger->warning("Tried to create an object store folder that already exists: $path");
// The storage root is created on the fly by getMetaData() whenever the
// cache has no entry for it, so a caller that only wants to make sure the
// root exists would be warned about a folder this storage just created
// itself. An existing root is never an error, so say nothing about it.
if ($path !== '') {
$this->logger->warning("Tried to create an object store folder that already exists: '$path'");
}
return false;
}

Expand Down
Loading