Repository navigation
polishing of sidebar in public view #12132
Description
just tested on nc29.0.0b1
- The icons in system dark mode in the header look broken:
- Also the sidebar toggle button does not seem to work... fix(PublicShareSidebar): fix prop reactivity #12133
Metadata
Metadata
Assignees
Type
Projects
- Status
Activity
Pytal commentedon Apr 16, 2024
Seems to be the Talk public share sidebar, cc @danxuliu
nickvergessen commentedon Apr 17, 2024
Reopening as the icon color and file name color is still wrong if I see that correctly
nickvergessen commentedon Apr 17, 2024
And just for the record, we need to adjust the used variable, not the content of the variable. it claims to be a button tertiary-on-primary, but it's not on primary, it's on the background.
Might be non trivial to solve. Best is to check the color/variable used by the app list when you are logged in
Antreesy commentedon Apr 17, 2024
That's the result of applying
tertiary-no-background. But I'm not sure it's consistent:7 remaining items
susnux commentedon Jul 26, 2024
should be fixed with:
nextcloud/server#46785
susnux commentedon Jul 26, 2024
correct color is btw:
--color-background-plain-textAntreesy commentedon Jul 26, 2024
Nein, that indeed fixes the file name, but not the button =/
It's Talk-only now, so I'll take over from here