Fix call view shown if force reconnected when not in a call #10268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a force reconnection the local participant state is updated in the store. If the participant is not in a call the call flags will be null, but the store expects an integer as the call flag, and any value different from 0 (disconnected) is treated as "in the call". Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
bug
regression
feature: signaling 📶
Member
Author
|
/backport to stable27 |
Antreesy
deleted the
fix-call-view-shown-if-force-reconnected-when-not-in-a-call
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #10206
After a force reconnection the local participant state is updated in the store. If the participant is not in a call the call flags will be null, but the store expects an integer as the call flag, and any value different from 0 (disconnected) is treated as "in the call".
This should not happen in the real world, as forced reconnections are only triggered during calls and in that case the flags are properly set, but better fix it anyway ;-)
How to test
In the browser console, run
getSignaling().forceReconnect(true)Result with this pull request
There are no changes in the UI
Result without this pull request
The call view is shown, although the participant is not actually in the call