-
Notifications
You must be signed in to change notification settings - Fork 508
feat(conversation) - add Note to self conversation #10603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Outdated
Show resolved
Hide resolved
src/components/RightSidebar/Participants/ParticipantsList/Participant/Participant.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Outdated
Show resolved
Hide resolved
Antreesy
reviewed
Sep 29, 2023
src/components/ConversationSettings/ConversationSettingsDialog.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Outdated
Show resolved
Hide resolved
src/components/RightSidebar/Participants/ParticipantsList/Participant/Participant.vue
Outdated
Show resolved
Hide resolved
Contributor
Author
I ordered it based on the usage :
cc @nextcloud/designers |
e0011b2 to
6b8e5b2
Compare
Antreesy
reviewed
Sep 29, 2023
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Outdated
Show resolved
Hide resolved
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
…eview fixes Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
f49b222 to
f2dc533
Compare
Antreesy
reviewed
Oct 4, 2023
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/Forwarder.vue
Show resolved
Hide resolved
Antreesy
reviewed
Oct 4, 2023
Signed-off-by: DorraJaouad <[email protected]>
This was referenced Oct 4, 2023
Antreesy
approved these changes
Oct 4, 2023
Contributor
Antreesy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good as-is, doesn't break the previous behaviour
I've raised a follow-up and RFC issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
Forward a message to Note to self
https://github.com/nextcloud/spreed/assets/84044328/6335d4b9-7221-4842-8f86-0770ae325646
Restore
https://github.com/nextcloud/spreed/assets/84044328/1e3f593f-5be0-4604-9a6a-df601f829c1f
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required