Skip to content

Conversation

@DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Sep 27, 2023

☑️ Resolves

🖼️ Screenshots

Forward a message to Note to self
https://github.com/nextcloud/spreed/assets/84044328/6335d4b9-7221-4842-8f86-0770ae325646

Restore
https://github.com/nextcloud/spreed/assets/84044328/1e3f593f-5be0-4604-9a6a-df601f829c1f

🚧 Tasks

  • Remove the non-applicable settings
  • Add the option to restore the note to self conversation if it was removed
  • Add the option to forward a message to note to self
  • Add forward message action to the store and some follow-up refactoring where it is used
  • Write the relevant tests for the new action

🏁 Checklist

@DorraJaouad
Copy link
Contributor Author

What about labelling it as New personal note without capital letters, and put on a third place in the list?

I ordered it based on the usage :

  • Create a new conversation - the most common action
  • New personal note - taking personal notes is a useful but less common action than starting conversations and more relevant to the user on a daily basis ( it will appear only when the note to self does not exist)
  • Join open conversation - viewing existing conversations is helpful but not where most users will start or use it daily.

cc @nextcloud/designers

@DorraJaouad DorraJaouad force-pushed the feat/10405/note-to-self branch from e0011b2 to 6b8e5b2 Compare September 29, 2023 15:34
@DorraJaouad DorraJaouad force-pushed the feat/10405/note-to-self branch from f49b222 to f2dc533 Compare October 3, 2023 11:03
Signed-off-by: DorraJaouad <[email protected]>
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good as-is, doesn't break the previous behaviour
I've raised a follow-up and RFC issues

@DorraJaouad DorraJaouad merged commit 6159317 into master Oct 4, 2023
@DorraJaouad DorraJaouad deleted the feat/10405/note-to-self branch October 4, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants