-
Notifications
You must be signed in to change notification settings - Fork 509
Replace OC dialog with NcDialog #10812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ah, I missed this is still open. I bumped dialogs in #10821 So make sure to rebase and retest :) |
|
Before I move further, we should migrate the duplicate session dialog to NcDialog too, right? https://github.com/nextcloud/spreed/blob/main/src/store/participantsStore.js#L790-L825 It will be replaced by an event emission from the store and listened by the main components calling
For the others, like |
|
Lets do that in a different PR. It's a more problematic thing to check and test than the currently handled deletions. |
f590f29 to
eb843f1
Compare
nickvergessen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use error in all cases like you used already for the breakout room deletion
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
eb843f1 to
3e7a41c
Compare
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist