Skip to content

Conversation

@nickvergessen
Copy link
Member

Set the current message as comment content, so that the message finds mentions which are now part if the message but were not on the original comment, e.g. mentions at the beginning of captions

☑️ Resolves

🛠️ API Checklist

Before

    Then user "participant1" sees the following messages in room "public room" with 200 # FeatureContext::userSeesTheFollowingMessagesInRoom()
      | room        | actorType | actorId      | actorDisplayName         | message         | messageParameters |
      | public room | users     | participant1 | participant1-displayname | {mention-user1} | "IGNORE"          |
      Failed asserting that two arrays are equal.
      --- Expected
      +++ Actual
      @@ @@
               'actorType' => 'users'
               'actorId' => 'participant1'
               'actorDisplayName' => 'participant1-displayname'
      -        'message' => '{mention-user1}'
      +        'message' => '@participant2'
               'messageParameters' => '"IGNORE"'
           )
       )

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings labels Nov 3, 2023
@nickvergessen nickvergessen added this to the 💙 Next Beta (28) milestone Nov 3, 2023
@nickvergessen nickvergessen self-assigned this Nov 3, 2023
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on web and on iOS

Set the current message as comment content, so that the message finds
mentions which are now part if the message but were not on the original
comment, e.g. mentions at the beginning of captions

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the bugfix/10830/mentions-at-beginning-of-captions branch from 7e9ff68 to 332eb37 Compare November 3, 2023 08:41
@nickvergessen nickvergessen merged commit 1e5c84a into main Nov 3, 2023
@nickvergessen nickvergessen deleted the bugfix/10830/mentions-at-beginning-of-captions branch November 3, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mentioning in file captions does not work when at the start of the caption

3 participants