Skip to content

Conversation

@DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Nov 6, 2023

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Code review

🏁 Checklist

@DorraJaouad DorraJaouad added this to the 💙 Next Beta (28) milestone Nov 6, 2023
@DorraJaouad DorraJaouad requested a review from ShGKme November 6, 2023 08:03
@DorraJaouad DorraJaouad self-assigned this Nov 6, 2023
readableTime: key,
timeLocale: moment?.format('LT'),
}),
ariaLabel: t('spreed', `Set reminder for ${key.toLowerCase()}`),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work for translations. Please revert to old pattern with fixed strings.

See https://docs.nextcloud.com/server/latest/developer_manual/basics/front-end/l10n.html#important-notes for more information

Copy link
Contributor Author

@DorraJaouad DorraJaouad Nov 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The aria label is translatable but I am not sure if the text label is translatable. I think that's where the translation broke ?
image

Anyway, for such cases, how to translate strings with variable part that should be translated ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, for such cases, how to translate strings with variable part that should be translated ?

This is called string concatenation and does not work in all languages. Just don't use variabled strings. Go back to the predefined array that was here. (It's also unrelated to "Hide copy message button")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was just an attempt to reduce the redundancy

@DorraJaouad DorraJaouad force-pushed the fix/10829/hide-copy-formatted-message branch from dd3f7f4 to a9ef89b Compare November 6, 2023 13:25
@nickvergessen nickvergessen merged commit fa3e04f into main Nov 7, 2023
@nickvergessen nickvergessen deleted the fix/10829/hide-copy-formatted-message branch November 7, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Files without caption allow copying the message

4 participants