Skip to content

fix(shares): handle silent sending and input paste correctly #11122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 2 commits into from
Dec 5, 2023
Merged

fix(shares): handle silent sending and input paste correctly #11122

nickvergessen merged 2 commits into from
Dec 5, 2023

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Dec 5, 2023 •
edited by DorraJaouad
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🚧 Tasks

  • To test 11117:
    • as user 2, enable notification in conversation for "All messages"
  • To test 11118:
    • Ctrl+C, Ctrl+V

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • ⛑️ Tests are included or not possible

@Antreesy Antreesy added 3. to review bug feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings labels Dec 5, 2023
@Antreesy Antreesy added this to the 💞 Following Major (29) milestone Dec 5, 2023
@Antreesy Antreesy self-assigned this Dec 5, 2023
SystemKeeper
SystemKeeper approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both scenarios and they work for me!

DorraJaouad
DorraJaouad approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works

@nickvergessen
Copy link
Member

nickvergessen commented Dec 5, 2023

/backport to stable28

@nickvergessen nickvergessen merged commit 4810f2e into main Dec 5, 2023
@nickvergessen nickvergessen deleted the fix/11117/silent-share branch December 5, 2023 09:54
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 5, 2023
Merged
@Antreesy Antreesy mentioned this pull request Jan 2, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels

3. to review bug feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings

Projects

None yet

Milestone

v19.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

Pasting an image in the file preview dialog replaces existing image Add option to allow sending files silently

5 participants

@Antreesy @nickvergessen @SystemKeeper @DorraJaouad