Skip to content

Fix(Quote): Don't trim the quote when it is not image share with caption #11166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DorraJaouad merged 1 commit into from
Dec 14, 2023
Merged

Fix(Quote): Don't trim the quote when it is not image share with caption #11166

DorraJaouad merged 1 commit into from
Dec 14, 2023

Conversation

@DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Dec 8, 2023 •
edited by Antreesy
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Code review

🏁 Checklist

@DorraJaouad DorraJaouad added this to the 💞 Following Major (29) milestone Dec 8, 2023
@DorraJaouad DorraJaouad requested a review from Antreesy December 8, 2023 21:10
@DorraJaouad DorraJaouad self-assigned this Dec 8, 2023
@DorraJaouad DorraJaouad added the feature: frontend 🖌️ "Web UI" client label Dec 8, 2023
@Antreesy

This comment was marked as resolved.

Sign in to view
Antreesy
Antreesy reviewed Dec 11, 2023
View reviewed changes
@DorraJaouad DorraJaouad force-pushed the fix/noid/quote-height branch from e646e2e to 2e3e421 Compare December 13, 2023 06:58
@Antreesy

This comment was marked as resolved.

Sign in to view
@DorraJaouad DorraJaouad force-pushed the fix/noid/quote-height branch from 2e3e421 to 8cd8745 Compare December 13, 2023 22:44
@DorraJaouad DorraJaouad requested a review from Antreesy December 14, 2023 09:02
Antreesy
Antreesy reviewed Dec 14, 2023
View reviewed changes
@DorraJaouad DorraJaouad force-pushed the fix/noid/quote-height branch from 8cd8745 to 17a799f Compare December 14, 2023 09:41
@DorraJaouad DorraJaouad force-pushed the fix/noid/quote-height branch from 17a799f to 00dd761 Compare December 14, 2023 12:04
Antreesy
Antreesy approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@DorraJaouad DorraJaouad merged commit 2363e94 into main Dec 14, 2023
@DorraJaouad DorraJaouad deleted the fix/noid/quote-height branch December 14, 2023 15:30
@Antreesy
Copy link
Contributor

Antreesy commented Dec 14, 2023

/backport to stable28

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels

3. to review bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client regression

Projects

None yet

Milestone

v19.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

3 participants

@DorraJaouad @Antreesy