Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Mar 5, 2024

This is required for federated conversations where the clients might not know the hosted message ID but only the proxy ID instead

πŸ› οΈ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • πŸ“˜ API documentation in docs/ has been updated or is not required
  • πŸ”– Capability is added or not needed: chat-read-last

This is required for federated conversations where the clients
might not know the hosted message ID but only the proxy ID instead

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the feat/noid/allow-read-marking-without-id branch from 08e21d5 to 7d7765c Compare March 5, 2024 11:36
@nickvergessen nickvergessen enabled auto-merge March 5, 2024 11:37
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, need to rebase #11678 onto it

@nickvergessen nickvergessen merged commit 075cd25 into main Mar 5, 2024
@nickvergessen nickvergessen deleted the feat/noid/allow-read-marking-without-id branch March 5, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants