Skip to content

fix(MessagesList): remove deleted groups #11779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DorraJaouad merged 1 commit into from
Mar 12, 2024
Merged

fix(MessagesList): remove deleted groups #11779

DorraJaouad merged 1 commit into from
Mar 12, 2024

Conversation

@DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Mar 12, 2024

☑️ Resolves

  • Removal update was missing for date groups level. So clear history didn't remove past groups by date.

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added regression feature: chat 💬 Chat and system messages labels Mar 12, 2024
@DorraJaouad DorraJaouad added this to the 💞 Next Beta (29) milestone Mar 12, 2024
@DorraJaouad DorraJaouad requested a review from Antreesy March 12, 2024 10:56
@DorraJaouad DorraJaouad self-assigned this Mar 12, 2024
Antreesy
Antreesy approved these changes Mar 12, 2024
View reviewed changes
@DorraJaouad DorraJaouad force-pushed the fix/noid/update-messages-groups-when-removed branch from c0cdb01 to 0f62360 Compare March 12, 2024 11:44
@DorraJaouad DorraJaouad merged commit 264ddc1 into main Mar 12, 2024
@DorraJaouad DorraJaouad deleted the fix/noid/update-messages-groups-when-removed branch March 12, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels

feature: chat 💬 Chat and system messages regression

Projects

None yet

Milestone

v19.0.0-beta.2

Development

Successfully merging this pull request may close these issues.

3 participants

@DorraJaouad @Antreesy