Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Mar 12, 2024

🛠️ API Checklist

🩹 Patch

To "break" federation, add

throw new OCMProviderException('breaking');

as first line in
https://github.com/nextcloud/server/blob/ecb111cec74d96ed66e0880bef093d1156afa256/lib/private/Federation/CloudFederationProviderManager.php#L222-L224

🚧 Tasks

  • Fix retry delay so that we cover a longer time frame (72h at least)
  • Make sure we can retry messages that are longer than 4k chars
  • Delete retry jobs when the receiver does not know the conversation
  • Delete federated participants when the receiver does not know the conversation after receiving a OCM notification
    • Delete outgoing invites when the receiver does not know the conversation
  • Delete retry job when the receiver was removed from the room
  • Delete retry job when the receiver left the room

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 2. developing bug feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 labels Mar 12, 2024
@nickvergessen nickvergessen added this to the 💞 Next Beta (29) milestone Mar 12, 2024
@nickvergessen nickvergessen self-assigned this Mar 12, 2024
@nickvergessen nickvergessen force-pushed the bugfix/noid/fixing-retry-OCM branch 3 times, most recently from 341c11d to 4225e2f Compare March 12, 2024 17:18
@nickvergessen nickvergessen force-pushed the bugfix/noid/fixing-retry-OCM branch from 4225e2f to e29b401 Compare March 13, 2024 09:51
@nickvergessen nickvergessen enabled auto-merge March 13, 2024 09:52
@nickvergessen nickvergessen changed the title Bugfix/noid/fixing retry ocm fix(federation): Fix retrying to send OCM notifications with a proper scaling background job Mar 13, 2024
@nickvergessen nickvergessen merged commit a67611b into main Mar 13, 2024
@nickvergessen nickvergessen deleted the bugfix/noid/fixing-retry-OCM branch March 13, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages feature: federation 🌐

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants