Skip to content

fix(participants): show remote autocomplete options in search results #11794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 1 commit into from
Mar 14, 2024
Merged

fix(participants): show remote autocomplete options in search results #11794

Antreesy merged 1 commit into from
Mar 14, 2024

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 13, 2024 •
edited
Loading

☑️ Resolves

  • Server API returns autocompleted search results with source: remotes
  • Talk API is waiting for results with source: federated_users

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • ⛑️ Tests are included or not possible

@Antreesy Antreesy added this to the 💞 Next Beta (29) milestone Mar 13, 2024
@Antreesy Antreesy requested a review from nickvergessen March 13, 2024 16:43
@Antreesy Antreesy self-assigned this Mar 13, 2024
nickvergessen
nickvergessen approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the missing federation suggestions

@Antreesy Antreesy force-pushed the fix/noid/list-remote-options branch from 6b0d3d3 to 5e2de74 Compare March 14, 2024 09:40
@Antreesy Antreesy marked this pull request as ready for review March 14, 2024 09:40
@Antreesy Antreesy enabled auto-merge March 14, 2024 09:41
@Antreesy Antreesy merged commit 891ede4 into main Mar 14, 2024
@Antreesy Antreesy deleted the fix/noid/list-remote-options branch March 14, 2024 09:44
@nickvergessen nickvergessen mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@Antreesy Antreesy

Labels

3. to review bug feature: federation 🌐

Projects

None yet

Milestone

v19.0.0-beta.2

Development

Successfully merging this pull request may close these issues.

3 participants

@Antreesy @nickvergessen