Skip to content

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 16, 2024

Backport of #11818

Hopefully last bump for stable28, fix:

  • focus trap errors
  • reference widgets flickering
  • capture tribute closing
  • require leading space for tribute
  • extra spaces when mentioning
  • status icons in Safari
  • status icons in NcAvatar menu

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it

@Antreesy Antreesy added 3. to review feature: frontend 🖌️ "Web UI" client dependencies Pull requests that update a dependency file labels Mar 16, 2024
@Antreesy Antreesy added this to the 💚 Next Patch (28) milestone Mar 16, 2024
@Antreesy Antreesy requested a review from DorraJaouad March 16, 2024 06:30
@Antreesy Antreesy self-assigned this Mar 16, 2024
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not fixed yet
image

Otherwise, everything is okay.

@Antreesy Antreesy merged commit 8a9ed46 into stable28 Mar 16, 2024
@Antreesy Antreesy deleted the backport/11818/stable28 branch March 16, 2024 11:18
@DorraJaouad
Copy link
Contributor

Well, I think it is shown because of the second error
https://github.com/nextcloud-libraries/nextcloud-vue/blob/e9660e5ff47b2430bd67cbf6246500be4997f72b/src/components/NcRichText/NcReferenceWidget.vue#L200
image

There is no mounted hook used in the component, the warn was also shown for NcDialog
image

@Antreesy
Copy link
Contributor Author

mounted hook is from upstream util
Most likely will be fixed with vueuse bump next time. See overview issue for the reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review dependencies Pull requests that update a dependency file feature: frontend 🖌️ "Web UI" client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants