Skip to content

Conversation

@DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Mar 17, 2024

☑️ Resolves

Main chat input stays empty when upload editor is open.

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added this to the 💞 Next Beta (29) milestone Mar 17, 2024
@DorraJaouad DorraJaouad requested a review from Antreesy March 17, 2024 19:35
@DorraJaouad DorraJaouad self-assigned this Mar 17, 2024
@nickvergessen
Copy link
Member

Random thought, instead of clearing it, could we "hide" it? :P

@Antreesy
Copy link
Contributor

instead of clearing it, could we "hide" it? :P

Opacity applies only partly (wouldn't work here for text nodes), and some guards from the PR are nice to have to prevent some side computations

@DorraJaouad
Copy link
Contributor Author

Random thought, instead of clearing it, could we "hide" it? :P

It will use some invisible computations that we don't need.

@DorraJaouad DorraJaouad force-pushed the fix/noid/chat-input branch from 37ba68c to cf09396 Compare March 18, 2024 14:22
@Antreesy Antreesy merged commit 3693520 into main Mar 18, 2024
@Antreesy Antreesy deleted the fix/noid/chat-input branch March 18, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants