-
Notifications
You must be signed in to change notification settings - Fork 509
fix(SharedItems): fetch after page reload + fix(Conversation): set warnings on max length #11868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Maksim Sukharev <[email protected]>
DorraJaouad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better if you show max length somewhere ( either in a counter or in error message) so if a user pastes a text, they can know how many characters they should reduce.
What about |
Let's not depend on that, diff can be get to extreme cases easily (100000000000000000) and won't look good |
b09573d to
66d1cab
Compare
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
66d1cab to
d091484
Compare
|
Thank you! Is it possible to backport this to earlier Nextcloud versions like 28, 27? |
|
/backport to stable28 |
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist