Skip to content

Fix(PresenterOverlay): Add grabbing cursor #11903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 2 commits into from
Mar 26, 2024
Merged

Fix(PresenterOverlay): Add grabbing cursor #11903

Antreesy merged 2 commits into from
Mar 26, 2024

Conversation

@DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Mar 22, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏡 After

Recording.2024-03-22.161350.mp4

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added this to the 💞 Next Beta (29) milestone Mar 22, 2024
@DorraJaouad DorraJaouad requested a review from Antreesy March 22, 2024 16:01
@DorraJaouad DorraJaouad self-assigned this Mar 22, 2024
Antreesy
Antreesy reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't test it, but by screencast lookg and works good)
Couple of comments:

Antreesy
Antreesy approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested now

@DorraJaouad
Fix(PresenterOverlay): move PresenterOverlay to a different component…
5f2881a 
… and add grabbing effects

Signed-off-by: DorraJaouad <[email protected]>
@DorraJaouad
fix: lint and comments
2a06419 
Signed-off-by: DorraJaouad <[email protected]>
@DorraJaouad DorraJaouad force-pushed the enh/11869/add-grabber-pointer branch from a9d8e5a to 2a06419 Compare March 26, 2024 15:31
@Antreesy Antreesy merged commit f28c5c4 into main Mar 26, 2024
@Antreesy Antreesy deleted the enh/11869/add-grabber-pointer branch March 26, 2024 15:35
This was referenced Mar 28, 2024
Merged
Merged
@DorraJaouad DorraJaouad mentioned this pull request Apr 16, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels

enhancement feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v19.0.0-rc.1

Development

Successfully merging this pull request may close these issues.

Use cursor:grab for the floating videostream on top of screenshares

4 participants

@DorraJaouad @Antreesy @nickvergessen