Skip to content

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Apr 15, 2024

☑️ Resolves

  • Fix regression from fix(avatars): show Talk-defined avatar thumbnails in modals #11811
  • For BG color specifity was increased, so it follows:
    • server/component styles (0.2.0);
    • light theme in-Talk styles (0.3.0);
    • dark theme in-Talk styles (0.4.1);
    • system dark theme in-Talk styles (0.3.0 @media);
  • Increase size for mention bubble (see screenshots)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

☀️ Light theme 🌑 Dark Theme
image image
Before After
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it

@Antreesy Antreesy added bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client labels Apr 15, 2024
@Antreesy Antreesy added this to the 💙 Next Major (30) milestone Apr 15, 2024
@Antreesy Antreesy requested a review from DorraJaouad April 15, 2024 08:31
@Antreesy Antreesy self-assigned this Apr 15, 2024
@nickvergessen
Copy link
Member

For me the color is still different:
grafik

Even more obvious when mentioning:
grafik

@Antreesy Antreesy force-pushed the fix/11811/avatar-css-specificity branch from ef5784f to 7162fd4 Compare April 15, 2024 12:30
@Antreesy Antreesy requested a review from nickvergessen April 15, 2024 12:31
@Antreesy Antreesy force-pushed the fix/11811/avatar-css-specificity branch from 7162fd4 to cb4f85f Compare April 15, 2024 14:56
@Antreesy Antreesy requested a review from nickvergessen April 15, 2024 14:58
@nickvergessen
Copy link
Member

It had broken the "force bright theme" with "dark os".
I added a patch to fix that.

@Antreesy
Copy link
Contributor Author

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants