[stable29] enh(LobbySettings): add timezone and relative time #12135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
added
3. to review
enhancement
feature: frontend 🖌️
DorraJaouad
force-pushed
the
backport/12032/stable29
branch
from
e17d89c to
276c152
Compare
Signed-off-by: DorraJaouad <[email protected]>
DorraJaouad
force-pushed
the
backport/12032/stable29
branch
from
276c152 to
e8711a4
Compare
| return '' | ||
| } | ||
| const date = new Date(this.lobbyTimer) | ||
| return t('spreed', `Start time: ${date}`) |
Member
There was a problem hiding this comment.
This is illegal... It will always be english and never translated.
return t('spreed', 'Start time: {date}', { date })
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #12032