[stable29] fix(media): Fix initial selection of devices #12152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lists of preferences are used to select the default input devices when none was selected yet, so they need to be populated first. Otherwise the first time that the devices are updated the lists will be empty, so no default device would be set. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
When no permissions were given yet a single device of each kind with an empty deviceId may be returned (it is in the MediaDevices spec, but implemented by Chromium and not by Firefox yet). Those devices are not registered in the preference lists, so the lists are empty and no default devices are set. Indirectly this causes that no media is requested by the media settings dialog, so no permissions are asked for and thus the list is not updated with the real devices either. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
backportbot
bot
added
3. to review
bug
feature: frontend 🖌️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #12151