Skip to content

fix(MessageBody): pass actorId and actorType as props to the component #12175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 1 commit into from
Apr 20, 2024
Merged

fix(MessageBody): pass actorId and actorType as props to the component #12175

Antreesy merged 1 commit into from
Apr 20, 2024

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Apr 20, 2024

☑️ Resolves

  • Pass actorId and actorType to MessageBody as props (not attrs)
  • Allows to correctly check for message ownership

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it

@Antreesy Antreesy added this to the 💙 Next Major (30) milestone Apr 20, 2024
@Antreesy Antreesy requested a review from DorraJaouad April 20, 2024 06:59
@Antreesy Antreesy self-assigned this Apr 20, 2024
@Antreesy
Copy link
Contributor Author

Antreesy commented Apr 20, 2024

/backport to stable29

@Antreesy Antreesy merged commit 0b17b66 into main Apr 20, 2024
@Antreesy Antreesy deleted the fix/12158/actor-props branch April 20, 2024 07:03
@backportbot backportbot bot mentioned this pull request Apr 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels

3. to review bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v20.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Antreesy @DorraJaouad