[stable29] Follow-up: chat scrolling refactoring #12199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
added
3. to review
feature: chat 💬
nickvergessen
previously requested changes
Apr 24, 2024
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Let's first test this with a custom desktop client build and not merge it, in case an early 19.0.1 would be needed
Antreesy
force-pushed
the
backport/11943/stable29
branch
from
be2fbfd to
6344b1e
Compare
Antreesy
approved these changes
May 29, 2024
Contributor
There was a problem hiding this comment.
Rebased and rechecked according to the original PR
Have tested it with Desktop client (build against main, but today against stable29 as well) for this month, and haven't found any quirks regarding to changed behaviour, quite the opposite:
- preloaded chat don't jump to the very top, triggering old messages fetching
- don't drop unread messages because of scrolling
- more stable during conversations switch
Member
|
Then time for review by @ShGKme and @DorraJaouad |
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
…apsed Signed-off-by: DorraJaouad <[email protected]>
DorraJaouad
force-pushed
the
backport/11943/stable29
branch
from
6344b1e to
b6878e1
Compare
Contributor
|
Rebased and added #12205 (a fix for an issue noticed in testing) |
ShGKme
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #11943
Backport of #12205
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
EventBus.$emitwas replaced withEventBus.emit, which was for main/vue3 onlyLearn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.