Skip to content

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented May 7, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image

🚧 Tasks

  • Focus submitButton if there is no input

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@ShGKme ShGKme requested review from Antreesy and DorraJaouad May 7, 2024 06:39
@ShGKme ShGKme self-assigned this May 7, 2024
@ShGKme ShGKme force-pushed the fix/focus-on-submit-button-on-file-upload-without-caption branch from 598f8e9 to 76e7ec2 Compare May 7, 2024 06:39
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✅

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShGKme ShGKme merged commit c139a64 into main May 7, 2024
@ShGKme ShGKme deleted the fix/focus-on-submit-button-on-file-upload-without-caption branch May 7, 2024 09:00
@ShGKme
Copy link
Contributor Author

ShGKme commented May 7, 2024

/backport to stable29

@ShGKme
Copy link
Contributor Author

ShGKme commented May 7, 2024

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Press Enter on Send Image confirmation dismiss operation

4 participants