Skip to content

[stable28] fix(PublicShareSidebar): fix prop reactivity #12494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DorraJaouad merged 1 commit into from
Jun 11, 2024
Merged

[stable28] fix(PublicShareSidebar): fix prop reactivity #12494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/mainPublicShareSidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
*/

import { createPinia, PiniaVuePlugin } from 'pinia'
import Vue from 'vue'
import Vue, { reactive } from 'vue'
import VueObserveVisibility from 'vue-observe-visibility'
import vOutsideEvents from 'vue-outside-events'
import VueShortKey from 'vue-shortkey'
Expand Down Expand Up @@ -84,9 +84,9 @@ adjustLayout()
// An "isOpen" boolean should be passed to the component, but as it is a
// primitive it would not be reactive; it needs to be wrapped in an object and
// that object passed to the component to get reactivity.
const sidebarState = {
const sidebarState = reactive({
isOpen: false,
}
})

// Open the sidebar by default based on the window width using the same
// threshold as in the main Talk UI (in Talk 7).
Expand Down