fix(MessagesList): fix unread marker when it is attached to the last message in collapsed group #12584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
reviewed
Jun 26, 2024
…message in collapsed group Signed-off-by: DorraJaouad <[email protected]>
DorraJaouad
force-pushed
the
fix/read-marker
branch
from
4e5dbf1 to
aff48e0
Compare
Antreesy
approved these changes
Jun 27, 2024
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Tested for described case
Contributor
Author
|
/backport to stable29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
There is a special workaround when last read message is the last message in a collapsed group: we set the unread marker to the combined system message instead #11876. Thus, when checking
data-seenattribute, it should check the attribute of the combined system message.🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏚️ Before |
Conversations cannot be cleared from unread messages if the unread marker is attached to a combined system message.
🏡 After
Conversations can be cleared from unread messages.
🏁 Checklist