fix: Banned user cannot be added to the room #12801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skalidindi53
force-pushed
the
skalidindi53/12793/Cannot-add-banned-user
branch
2 times, most recently
from
eb7e004 to
ea0b876
Compare
skalidindi53
force-pushed
the
skalidindi53/12793/Cannot-add-banned-user
branch
2 times, most recently
from
69d8850 to
8c70d78
Compare
Contributor
Author
|
This also fixes issue #12794 |
skalidindi53
force-pushed
the
skalidindi53/12793/Cannot-add-banned-user
branch
from
8c70d78 to
d5777d6
Compare
2 tasks
nickvergessen
requested changes
Jul 29, 2024
skalidindi53
force-pushed
the
skalidindi53/12793/Cannot-add-banned-user
branch
3 times, most recently
from
54139b9 to
ab779db
Compare
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Can you also add a test where participant2 is part of a group and the group is added after participant2 got banned? I think they will be pinged with a notification and everything 🙈
Same mostlikely happens with a circle/team
skalidindi53
force-pushed
the
skalidindi53/12793/Cannot-add-banned-user
branch
from
7cc4edb to
e884ff4
Compare
skalidindi53
force-pushed
the
skalidindi53/12793/Cannot-add-banned-user
branch
from
e884ff4 to
a10b43c
Compare
Signed-off-by: skalidindi53 <[email protected]>
nickvergessen
force-pushed
the
skalidindi53/12793/Cannot-add-banned-user
branch
from
a10b43c to
0fedb33
Compare
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
skalidindi53/12793/Cannot-add-banned-user
branch
from
0fedb33 to
c66439d
Compare
nickvergessen
approved these changes
Aug 2, 2024
Member
|
Added the tests and fixed group+circles handling |
Signed-off-by: skalidindi53 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required