Skip to content

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 25, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after
image image
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@nickvergessen

This comment was marked as resolved.

@Antreesy

This comment was marked as resolved.

@Antreesy Antreesy force-pushed the fix/noid/refactor-participant-item branch from 5796c13 to 3caff94 Compare August 3, 2024 09:05
- replace v-tooltip with native title
- optimize icon render template
- simplify class names

Signed-off-by: Maksim Sukharev <[email protected]>
- not supported by ListItem

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/noid/refactor-participant-item branch from 3caff94 to b904ecc Compare August 5, 2024 16:14
@Antreesy Antreesy requested review from DorraJaouad and ShGKme August 5, 2024 16:14
@Antreesy Antreesy marked this pull request as ready for review August 5, 2024 16:15
@Antreesy Antreesy force-pushed the fix/noid/refactor-participant-item branch from b904ecc to 661b1fd Compare August 5, 2024 19:01
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is almost ready 🌟

@Antreesy Antreesy force-pushed the fix/noid/refactor-participant-item branch from 661b1fd to 8b2a46d Compare August 6, 2024 12:34
@Antreesy Antreesy force-pushed the fix/noid/refactor-participant-item branch from 8b2a46d to 73499e6 Compare August 6, 2024 13:11
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG 🦅

@Antreesy Antreesy merged commit 2018b17 into main Aug 6, 2024
@Antreesy Antreesy deleted the fix/noid/refactor-participant-item branch August 6, 2024 14:06
@ShGKme
Copy link
Contributor

ShGKme commented Aug 7, 2024

Follow-ups:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants