Skip to content

fix(Reactions): integrate reactions into grid CSS layout #12854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 1 commit into from
Aug 5, 2024
Merged

fix(Reactions): integrate reactions into grid CSS layout #12854

Antreesy merged 1 commit into from
Aug 5, 2024

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 30, 2024

☑️ Resolves

  • Based on top of fix(MessageList): rewrite CSS layout of chat #12823
  • make reactions wrapper a part of message grid, so it is aware of available width (date deducted)
  • rewrite styles to default 'small' NcButton
  • add thumbnails to reserve space for appearing icons (to avoid chat jumping)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
react-before react-after

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 💙 Next Beta (30) milestone Jul 30, 2024
@Antreesy Antreesy requested a review from ShGKme July 30, 2024 15:54
@Antreesy Antreesy self-assigned this Jul 30, 2024
ShGKme
ShGKme approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Antreesy Antreesy force-pushed the fix/noid/chat-layout-rewrite branch from b9e6e42 to aa55862 Compare August 1, 2024 14:20
@Antreesy Antreesy force-pushed the fix/noid/chat-layout-rewrite branch 2 times, most recently from a59c24a to 7b9c399 Compare August 5, 2024 10:50
Base automatically changed from fix/noid/chat-layout-rewrite to main August 5, 2024 11:07
@Antreesy
fix(Reactions): inject reactions in grid layout, drop unused styles, …
b9ccd46 
…add thumbnails to reserve space for hover buttons

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/noid/chat-layout-rewrite-reactions branch from 657f1ec to b9ccd46 Compare August 5, 2024 12:06
@Antreesy Antreesy requested a review from DorraJaouad August 5, 2024 12:13
DorraJaouad
DorraJaouad approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 🦅

@Antreesy Antreesy merged commit 43743c9 into main Aug 5, 2024
@Antreesy Antreesy deleted the fix/noid/chat-layout-rewrite-reactions branch August 5, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels

3. to review bug feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v20.0.0-beta.3

Development

Successfully merging this pull request may close these issues.

5 participants

@Antreesy @ShGKme @DorraJaouad @nickvergessen