Skip to content

fix(MessagesList): position loading spinner to not affect scrolling #12855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 1 commit into from
Aug 5, 2024
Merged

fix(MessagesList): position loading spinner to not affect scrolling #12855

Antreesy merged 1 commit into from
Aug 5, 2024

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 30, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
load-before load-after
Wide chat Call sidebar
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added 3. to review feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client labels Jul 30, 2024
@Antreesy Antreesy added this to the 💙 Next Beta (30) milestone Jul 30, 2024
@Antreesy Antreesy requested a review from ShGKme July 30, 2024 18:57
@Antreesy Antreesy self-assigned this Jul 30, 2024
@DorraJaouad DorraJaouad self-requested a review August 1, 2024 12:44
@Antreesy Antreesy force-pushed the fix/noid/chat-layout-rewrite branch from b9e6e42 to aa55862 Compare August 1, 2024 14:20
@Antreesy Antreesy force-pushed the fix/noid/chat-layout-rewrite branch 2 times, most recently from a59c24a to 7b9c399 Compare August 5, 2024 10:50
Base automatically changed from fix/noid/chat-layout-rewrite to main August 5, 2024 11:07
@Antreesy Antreesy force-pushed the fix/noid/chat-layout-rewrite-loader branch from c27d8a4 to 048641b Compare August 5, 2024 12:03
@Antreesy Antreesy merged commit cb423c2 into main Aug 5, 2024
@Antreesy Antreesy deleted the fix/noid/chat-layout-rewrite-loader branch August 5, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels

3. to review feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v20.0.0-beta.3

Development

Successfully merging this pull request may close these issues.

5 participants

@Antreesy @ShGKme @DorraJaouad @nickvergessen