Skip to content

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 31, 2024

☑️ Resolves

  • Fix duplicated requests and reloads, if different federated rooms belong to the same remote server

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Added some logs for visibility:

  • for clean storage or new server - works as before, asking to reload the page
  • for next, if server matches - update token map, cache new token for future
  • in Network - no new requests for 'capabilities'
Screencast.from.31.07.2024.13.50.16.webm

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • ⛑️ Tests are included or not possible

@Antreesy Antreesy added this to the 💙 Next Beta (30) milestone Jul 31, 2024
@Antreesy Antreesy self-assigned this Jul 31, 2024
@Antreesy Antreesy force-pushed the fix/noid/dedupe-remote-capabilities branch from 2e04b0e to c756163 Compare August 2, 2024 09:01
@Antreesy Antreesy marked this pull request as ready for review August 2, 2024 09:01
@Antreesy Antreesy requested review from DorraJaouad and ShGKme August 2, 2024 09:02
@Antreesy Antreesy force-pushed the fix/noid/dedupe-remote-capabilities branch from c756163 to b1a39b3 Compare August 2, 2024 09:34
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First commit

@Antreesy Antreesy force-pushed the fix/noid/dedupe-remote-capabilities branch from 0c21620 to 3f1b50e Compare August 6, 2024 16:18
@DorraJaouad
Copy link
Contributor

to also change isFederationEnabled from state to config
capabilities?.spreed?.config?.federation?.enabled

@Antreesy Antreesy force-pushed the fix/noid/dedupe-remote-capabilities branch from 3f1b50e to 001feb4 Compare August 14, 2024 07:36
@nickvergessen
Copy link
Member

/backport to stable30

@nickvergessen
Copy link
Member

Whats the state here?

@Antreesy
Copy link
Contributor Author

Whats the state here?

Ready IMO, waiting for reviews

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants