Skip to content

Fix: revert two line avatar size to default #12869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 1 commit into from
Aug 6, 2024
Merged

Fix: revert two line avatar size to default #12869

Antreesy merged 1 commit into from
Aug 6, 2024

Conversation

@marcoambrosini
Copy link
Member

@marcoambrosini marcoambrosini commented Jul 31, 2024 •
edited by Antreesy
Loading

  • Revert commit 12ec9ba
  • Reduce space between elements to 4px (outline)
  • Return avatar size to 44px
Screenshot 2024-07-31 at 18 01 44

@marcoambrosini marcoambrosini marked this pull request as draft July 31, 2024 16:03
@marcoambrosini marcoambrosini self-assigned this Aug 1, 2024
@Antreesy
revert: increase icon size to match two-lines layout height
77f2cc8 
This partially reverts commit 12ec9ba.

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the feature/noid/fix-conversations-layout branch from 3dce07c to 77f2cc8 Compare August 6, 2024 14:41
@Antreesy Antreesy marked this pull request as ready for review August 6, 2024 14:45
@Antreesy Antreesy requested review from DorraJaouad and ShGKme August 6, 2024 14:45
@Antreesy
Copy link
Contributor

Antreesy commented Aug 6, 2024

Rebased and revert previous commit, which was supposed to adjust height.
Now avatars should be reduced to initial 44px, and we can discuss changes later from there.

@ShGKme ShGKme added this to the 💙 Next Beta (30) milestone Aug 6, 2024
@Antreesy Antreesy merged commit 0cc3e49 into main Aug 6, 2024
@Antreesy Antreesy deleted the feature/noid/fix-conversations-layout branch August 6, 2024 15:12
@ShGKme ShGKme changed the title Fix conversations layout Fix: revert two line avatar size to default Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@marcoambrosini marcoambrosini

@Antreesy Antreesy

Labels

2. developing bug design feature: frontend 🖌️ "Web UI" client

Projects

🖍 Design team
Archived in project

Milestone

v20.0.0-beta.3

Development

Successfully merging this pull request may close these issues.

5 participants

@marcoambrosini @Antreesy @ShGKme @DorraJaouad