-
Notifications
You must be signed in to change notification settings - Fork 509
fix(TopBar): align lines #12875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TopBar): align lines #12875
Conversation
df90b83 to
5743491
Compare
|
I don't think this is ok for accessibility. Could check that? |
d6ef3b8 to
afea58c
Compare
|
Updated to normal font-size with normal line-height everywhere |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Grigorii K. Shartsev <[email protected]>
afea58c to
41e1e23
Compare
|
| align-items: center; | ||
| justify-content: flex-end; | ||
| min-height: calc(2 * var(--default-grid-baseline) + var(--text-height) + var(--border-width)); | ||
| min-height: calc(var(--border-width) + 2 * (2 * var(--default-grid-baseline)) + var(--default-clickable-area)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call Container uses magic number 60 or close, need to be updated to the same value there too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in a hotfix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but I thought, we're going for variables)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found it more complex and risky. CallView is used in different entrypoints and not directly related to TopBar
Signed-off-by: Grigorii K. Shartsev <[email protected]>
|
Follow-up: use CSS variables in call view |




☑️ Resolves
line-heightone-line is 1.5 height of fontnormal(about 1.2) line height ensures that the text is not cut off but also has no extra height even with normal font-size🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist