Skip to content

fix(ConversationSettings): hide ban section in note to self #12889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Aug 2, 2024
Merged

fix(ConversationSettings): hide ban section in note to self #12889

nickvergessen merged 1 commit into from
Aug 2, 2024

Conversation

@DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Aug 2, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added this to the 💙 Next Beta (30) milestone Aug 2, 2024
@DorraJaouad DorraJaouad requested a review from Antreesy August 2, 2024 08:55
@DorraJaouad DorraJaouad self-assigned this Aug 2, 2024
@DorraJaouad DorraJaouad force-pushed the fix/12880/hide-ban-users branch from 61b1c09 to 44ee57e Compare August 2, 2024 10:47
@nickvergessen nickvergessen merged commit 59a4959 into main Aug 2, 2024
@nickvergessen nickvergessen deleted the fix/12880/hide-ban-users branch August 2, 2024 11:27
@ShGKme ShGKme mentioned this pull request Aug 6, 2024
Merged
@nickvergessen nickvergessen mentioned this pull request Aug 12, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels

bug feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v20.0.0-beta.3

Development

Successfully merging this pull request may close these issues.

Hide ban section in settings of Note-to-self

4 participants

@DorraJaouad @nickvergessen @Antreesy