Skip to content

fix(ConversationIcon): show avatar thumbnail for former 1-1 conversations #12891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Aug 2, 2024
Merged

fix(ConversationIcon): show avatar thumbnail for former 1-1 conversations #12891

nickvergessen merged 1 commit into from
Aug 2, 2024

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Aug 2, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible

@Antreesy Antreesy added this to the 💙 Next Beta (30) milestone Aug 2, 2024
@Antreesy Antreesy self-assigned this Aug 2, 2024
nickvergessen
nickvergessen approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@nickvergessen
Copy link
Member

nickvergessen commented Aug 2, 2024

Was this backported to 29?

@SystemKeeper
Copy link
Contributor

SystemKeeper commented Aug 2, 2024

Doesn't seem like it: #12214
But might be worth checking the other conditions: be5fc41

@Antreesy
Copy link
Contributor Author

Antreesy commented Aug 2, 2024

But might be worth checking the other conditions

All other components are not affected, since conversation is locked, and we can't edit/delete/call

@nickvergessen nickvergessen merged commit 0f5b28b into main Aug 2, 2024
@nickvergessen nickvergessen deleted the fix/12886/former-user-avatar branch August 2, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@SystemKeeper SystemKeeper Awaiting requested review from SystemKeeper

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels

3. to review bug feature: conversations 👥 feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v20.0.0-beta.3

Development

Successfully merging this pull request may close these issues.

Avatars of former one-to-one conversations are broken

4 participants

@Antreesy @nickvergessen @SystemKeeper