Skip to content

fix(RightSidebar): discard unread messages toast on conversation change #12906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ShGKme merged 2 commits into from
Aug 6, 2024
Merged

fix(RightSidebar): discard unread messages toast on conversation change #12906

ShGKme merged 2 commits into from
Aug 6, 2024

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Aug 6, 2024 •
edited
Loading

☑️ Resolves

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@ShGKme ShGKme added this to the 💙 Next Beta (30) milestone Aug 6, 2024
@ShGKme ShGKme requested review from Antreesy and DorraJaouad August 6, 2024 12:44
@ShGKme ShGKme self-assigned this Aug 6, 2024
@ShGKme ShGKme changed the title fix(RightSidebar): discard unread messages on conversation change fix(RightSidebar): discard unread messages toast on conversation change Aug 6, 2024
@ShGKme ShGKme force-pushed the fix/RightSidebar--notifyUnreadMessages-it-not-a-function branch from 2bcfd29 to f6a717d Compare August 6, 2024 12:44
@ShGKme ShGKme merged commit bced634 into main Aug 6, 2024
@ShGKme ShGKme deleted the fix/RightSidebar--notifyUnreadMessages-it-not-a-function branch August 6, 2024 14:10
@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 6, 2024

/backport to stable29

@backportbot backportbot bot mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@Antreesy Antreesy Antreesy approved these changes

Assignees

@ShGKme ShGKme

Labels

3. to review bug feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v20.0.0-beta.3

Development

Successfully merging this pull request may close these issues.

4 participants

@ShGKme @DorraJaouad @Antreesy