fix: make more obvious that you can add Federated Cloud ID accounts #12916
Conversation
|
Should we make that dependent on federation enabled/allowed? |
Yes, but currently I don't know what's the best way to show the text. It's too long for this field. |
|
Ah, input is in #12912 (comment) |
|
@ShGKme would be nice to get this in before tomorrows RC1 which is the translation string freeze |
Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
force-pushed
the
fix/list-posibilities-in-participants-search
branch
from
96f427c to
ac0a4fc
Compare
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Also looks fine with Dialpad panel
| :title="searchBoxDescription" | ||
| class="search-form__description"> | ||
| <IconInformationOutline :size="20" /> | ||
| <span class="hidden-visually">{{ searchBoxDescription }}</span> |
There was a problem hiding this comment.
Wouldn't aria-label be sufficient here? If not, I'm afraid, we might accidentally delete it in future, if it won't be specifically commented
There was a problem hiding this comment.
aria-label is only valid on elements discoverable via assistive technologies:
- An interactive element such as buttons
- lists, modals, navigation and other landmarks
In other cases, it must be a general text content
There was a problem hiding this comment.
Alternative is to remove the text here and set it as aria-desription on the input. But then I'm afraid it's even simpler to lose, because it would have no direct relation with the element.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist