Skip to content

fix(CallButton): replace video icon with phone #12927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ShGKme merged 2 commits into from
Aug 12, 2024
Merged

fix(CallButton): replace video icon with phone #12927

ShGKme merged 2 commits into from
Aug 12, 2024

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Aug 8, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after
image image
image image
image image
image image
image image

image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@ShGKme ShGKme added this to the 💙 Next Beta (30) milestone Aug 8, 2024
@ShGKme ShGKme self-assigned this Aug 8, 2024
DorraJaouad
DorraJaouad approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good choice of icons :)

jancborchardt
jancborchardt approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good point, nice fix! :)

@ShGKme ShGKme merged commit 5bd6b1b into main Aug 12, 2024
@ShGKme ShGKme deleted the fix/end-call-icon branch August 12, 2024 07:44
@jancborchardt jancborchardt mentioned this pull request Aug 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@ShGKme ShGKme

Labels

3. to review design feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v20.0.0-rc.1

Development

Successfully merging this pull request may close these issues.

End call button has the same icon as enable video on larger zoom levels

4 participants

@ShGKme @jancborchardt @DorraJaouad