Skip to content

fix(GuestWelcomeWindow): fix padding and text clipping #13138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DorraJaouad merged 1 commit into from
Aug 26, 2024
Merged

fix(GuestWelcomeWindow): fix padding and text clipping #13138

DorraJaouad merged 1 commit into from
Aug 26, 2024

Conversation

@DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Aug 26, 2024 •
edited
Loading

☑️ Resolves

  • Fix extra padding and margin
  • Fix description exceeding box.

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added this to the 💙 Next RC (30) milestone Aug 26, 2024
@DorraJaouad DorraJaouad requested a review from Antreesy August 26, 2024 11:45
@DorraJaouad DorraJaouad self-assigned this Aug 26, 2024
Antreesy
Antreesy reviewed Aug 26, 2024
View reviewed changes
@DorraJaouad DorraJaouad merged commit 09f2886 into main Aug 26, 2024
@DorraJaouad DorraJaouad deleted the fix/guest-window branch August 26, 2024 13:43
@DorraJaouad
Copy link
Contributor Author

DorraJaouad commented Aug 26, 2024

/backport to stable30

@backportbot backportbot bot mentioned this pull request Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels

3. to review feature: conversations 👥 feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v21.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

4 participants

@DorraJaouad @Antreesy @nickvergessen