fix(federation): Correctly handle decline in system messages #13150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
bug
feature: chat 💬
Member
Author
|
/backport to stable30 |
Antreesy
approved these changes
Aug 27, 2024
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Tested. Though I don't remember if it was intended to omit @cloudId remote part in some messages and keep in another ( or it's just confusing because of the same actorId)
| 1 | 2 |
|---|---|
 |
 |
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/13048/correctly-handle-deline-in-system-message
branch
from
2fb0def to
28238bf
Compare
skalidindi53
approved these changes
Aug 27, 2024
nickvergessen
deleted the
bugfix/13048/correctly-handle-deline-in-system-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🏁 Checklist
docs/has been updated or is not required