Skip to content

Conversation

@DorraJaouad
Copy link
Contributor

☑️ Resolves

  • Shadows are used only for elements on top of other elements, like menus/autocomplete

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added bug feature: frontend 🖌️ "Web UI" client feature: call 📹 Voice and video calls labels Aug 28, 2024
@DorraJaouad DorraJaouad added this to the 💙 Next RC (30) milestone Aug 28, 2024
@DorraJaouad DorraJaouad requested a review from Antreesy August 28, 2024 11:46
@DorraJaouad DorraJaouad self-assigned this Aug 28, 2024
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw also box-shadow on Contact.vue component, not sure if needed there.
But fine for now

@DorraJaouad
Copy link
Contributor Author

DorraJaouad commented Aug 28, 2024

Saw also box-shadow on Contact.vue component, not sure if needed there.

(in a follow up) It's used to aesthetic purposes, we usually use outlined border on hover and focus (like polls). Maybe switch to that style too?

@DorraJaouad DorraJaouad merged commit 450ce49 into main Aug 29, 2024
@DorraJaouad DorraJaouad deleted the fix/noid/avtar-shadow branch August 29, 2024 07:58
@DorraJaouad
Copy link
Contributor Author

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants