-
Notifications
You must be signed in to change notification settings - Fork 509
Share from Files wording fix (better consistency) #13605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @nickvergessen as was changed in original discussion: #7491 (comment) Can see in source code of Groupware/Office apps, that there is a translation 'from Files' |
Not sure to understand @Antreesy ; does my PR make sense ? |
|
It makes sense for me, but I want a confirmation, what was the reason to made it in the first place |
|
Since we use the code in the desktop client, "Files" is ambiguous and might cause confusion, so I think we have to stay with the product name. Edit: we could of course also show |
Signed-off-by: Jérôme Herbinet <[email protected]>
7d46582 to
76be22d
Compare
Antreesy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
/backport to stable30 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |


Just check the commit. The instance's name is useless. Elsewhere, in that kind of context, "... from Files" is used instead.
Test from reviewers are welcome.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required