Skip to content

Conversation

@Jerome-Herbinet
Copy link
Member

@Jerome-Herbinet Jerome-Herbinet commented Oct 21, 2024

Just check the commit. The instance's name is useless. Elsewhere, in that kind of context, "... from Files" is used instead.

Test from reviewers are welcome.

☑️ Resolves

  • Fix #…

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after

🚧 Tasks

  • ...

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

🛠️ API Checklist

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@Jerome-Herbinet Jerome-Herbinet changed the title Share from Files wording fix Share from Files wording fix (better consistancy) Oct 21, 2024
@Jerome-Herbinet Jerome-Herbinet changed the title Share from Files wording fix (better consistancy) Share from Files wording fix (better consistency) Oct 21, 2024
@Antreesy
Copy link
Contributor

cc @nickvergessen as was changed in original discussion: #7491 (comment)

Can see in source code of Groupware/Office apps, that there is a translation 'from Files'

@Jerome-Herbinet
Copy link
Member Author

cc @nickvergessen as was changed in original discussion: #7491 (comment)

Can see in source code of Groupware/Office apps, that there is a translation 'from Files'

Not sure to understand @Antreesy ; does my PR make sense ?

@Antreesy
Copy link
Contributor

It makes sense for me, but I want a confirmation, what was the reason to made it in the first place

@nickvergessen
Copy link
Member

nickvergessen commented Oct 22, 2024

Since we use the code in the desktop client, "Files" is ambiguous and might cause confusion, so I think we have to stay with the product name.

Edit: we could of course also show Share from Files in the browser and Share from {product} in the desktop?

@Antreesy Antreesy force-pushed the Jerome-Herbinet-share-wording-from-files-fix branch from 7d46582 to 76be22d Compare October 22, 2024 09:45
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in browser:
image
Desktop:
image

@Antreesy Antreesy merged commit b1d03f6 into main Oct 25, 2024
@Antreesy Antreesy deleted the Jerome-Herbinet-share-wording-from-files-fix branch October 25, 2024 07:59
@Antreesy
Copy link
Contributor

/backport to stable30

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants