Skip to content

feat: 🍱 Talk Dashboard - βš™οΈ API#14671

Merged
miaulalala merged 1 commit intomainfrom
feat/14407/talk-dashboard-api
May 5, 2025
Merged

feat: 🍱 Talk Dashboard - βš™οΈ API#14671
miaulalala merged 1 commit intomainfrom
feat/14407/talk-dashboard-api

Conversation

@miaulalala
Copy link
Copy Markdown
Contributor

@miaulalala miaulalala commented Mar 17, 2025

β˜‘οΈ Resolves

πŸ› οΈ API Checklist

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • πŸ“˜ API documentation in docs/ has been updated or is not required
  • πŸ”– Capability is added or not needed

@miaulalala miaulalala added this to the ⛰️ Summit milestone Mar 17, 2025
@miaulalala miaulalala self-assigned this Mar 17, 2025
Comment thread lib/Service/DashboardService.php Outdated
Comment thread lib/Service/DashboardService.php Outdated
@miaulalala miaulalala marked this pull request as ready for review March 24, 2025 10:36
Comment thread lib/Capabilities.php
Comment thread lib/Controller/DashboardController.php Outdated
Comment thread lib/Controller/DashboardController.php Outdated
Comment thread lib/Controller/DashboardController.php Outdated
Comment thread lib/Service/DashboardService.php Outdated
Comment thread docs/dashboard.md Outdated
Comment thread docs/capabilities.md Outdated
@miaulalala miaulalala added feature: api πŸ› οΈ OCS API for conversations, chats and participants feature: dashboard 🏠 Features relating to the Talk internal dashboard labels Mar 26, 2025
@miaulalala miaulalala requested review from SystemKeeper and nickvergessen and removed request for nickvergessen March 27, 2025 10:15
Comment thread lib/Controller/DashboardController.php Outdated
Comment thread lib/Service/DashboardService.php Outdated
Comment thread tests/integration/features/bootstrap/FeatureContext.php Outdated
Comment thread tests/integration/features/bootstrap/FeatureContext.php Outdated
Comment thread tests/integration/features/bootstrap/FeatureContext.php Outdated
Comment thread tests/integration/features/bootstrap/FeatureContext.php Outdated
Comment thread tests/integration/features/bootstrap/FeatureContext.php Outdated
Comment thread tests/integration/features/bootstrap/FeatureContext.php Outdated
Comment thread tests/integration/features/integration/dashboard-talk.feature Outdated
Copy link
Copy Markdown
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't take a look at the tests, but some things I noticed

Comment thread appinfo/routes/routesDashboardController.php
Comment thread lib/Controller/DashboardController.php Outdated
Comment thread lib/Service/DashboardService.php Outdated
@miaulalala miaulalala force-pushed the feat/14407/talk-dashboard-api branch from 79f1439 to bb47977 Compare April 1, 2025 13:35
@miaulalala
Copy link
Copy Markdown
Contributor Author

Failing test needs #14713 to work (it is correct).

@miaulalala miaulalala force-pushed the feat/14407/talk-dashboard-api branch 5 times, most recently from 587e4b2 to b6a4ed6 Compare April 9, 2025 18:04
@miaulalala miaulalala enabled auto-merge April 9, 2025 18:06
@miaulalala miaulalala marked this pull request as draft April 17, 2025 10:27
auto-merge was automatically disabled April 17, 2025 10:27

Pull request was converted to draft

@miaulalala
Copy link
Copy Markdown
Contributor Author

miaulalala commented Apr 28, 2025

To do:

  • fix unit tests
  • new integration tests
  • revert changes for dashboard test (old)

@miaulalala miaulalala force-pushed the feat/14407/talk-dashboard-api branch from ff3db41 to 97bb495 Compare April 30, 2025 13:20
@miaulalala miaulalala marked this pull request as ready for review April 30, 2025 13:38
@miaulalala miaulalala force-pushed the feat/14407/talk-dashboard-api branch 2 times, most recently from 313f63d to d3b47db Compare April 30, 2025 14:45
@Antreesy
Copy link
Copy Markdown
Contributor

Antreesy commented May 5, 2025

Couldn't add attachments to the event, but played a bit with rest features at ocs_api_viewer. Response payload looks good ✨

Copy link
Copy Markdown
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, with attachments

Comment thread lib/Service/DashboardService.php
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the feat/14407/talk-dashboard-api branch from 35af2ba to a9ebc8a Compare May 5, 2025 11:04
@miaulalala miaulalala merged commit 8be0c11 into main May 5, 2025
80 checks passed
@miaulalala miaulalala deleted the feat/14407/talk-dashboard-api branch May 5, 2025 11:24
@miaulalala
Copy link
Copy Markdown
Contributor Author

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: api πŸ› οΈ OCS API for conversations, chats and participants feature: dashboard 🏠 Features relating to the Talk internal dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🍱 Talk Dashboard - βš™οΈ API

5 participants