fix: Enable "encodedInsertableStreams" on browsers supporting it. #15197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older versions of Chrome (< 124) required the flag to be passed when creating PeerConnections so "createEncodedStreams" can be used later. See https://issues.chromium.org/issues/40943169 and https://chromiumdash.appspot.com/commit/ae3454745ca8f623435d658eba7d4bc2dc8aed17 With that also refactored the browser detection of features for E2EE. Signed-off-by: Joachim Bauch <[email protected]>
nickvergessen
added
3. to review
feature: WebRTC 🚡
nickvergessen
modified the milestones:
v22.0.0-beta.2,
🪺 Next RC (32),
🍏 Next Major (33)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of Chrome (< 124) required the flag to be passed when creating PeerConnections so "createEncodedStreams" can be used later.
See https://issues.chromium.org/issues/40943169 and https://chromiumdash.appspot.com/commit/ae3454745ca8f623435d658eba7d4bc2dc8aed17
With that also refactored the browser detection of features for E2EE.
The issue happened on one of my machines still on Chrome 122 (was developing on Chrome 132 which doesn't need the flag).