fix(capabilities): conditionally show links to calendar #15265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorraJaouad
reviewed
May 30, 2025
Contributor
DorraJaouad
left a comment
DorraJaouad
left a comment
There was a problem hiding this comment.
This is valid not only for dashboard but for mutual events and upcoming events ;)
Antreesy
force-pushed
the
fix/15249/hide-calendar-links
branch
from
daacd3d to
e2e5e29
Compare
DorraJaouad
approved these changes
Jun 2, 2025
ShGKme
reviewed
Jun 2, 2025
Antreesy
force-pushed
the
fix/15249/hide-calendar-links
branch
from
b822fb1 to
5902e5d
Compare
… is enabled Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
fix/15249/hide-calendar-links
branch
from
5902e5d to
79fc717
Compare
ShGKme
reviewed
Jun 2, 2025
Comment on lines
+96
to
+99
| $this->initialState->provideInitialState( | ||
| 'calendar_enabled', | ||
| $appManager->isEnabledForUser('calendar', $user) | ||
| ); |
Contributor
There was a problem hiding this comment.
I'm still not a fun of adding a new incorrect usage of the initial state...
Fine with it, if mobile clients don't need it.
Contributor
Author
|
Since API is added now, we can consider it? #15396 |
Member
|
That is an additional query per user opening the dashboard, sounds pretty bad to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
truefor Desktop, until it's settled on server capabilities PR🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist