Skip to content

Conversation

@DorraJaouad
Copy link
Contributor

☑️ Resolves

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad force-pushed the chore/noid/migrate-actor-store branch 2 times, most recently from 11aaac8 to f0c690a Compare June 6, 2025 20:00
@DorraJaouad DorraJaouad force-pushed the chore/noid/migrate-actor-store branch 2 times, most recently from 1c6fc2a to 51c4e0a Compare June 7, 2025 08:17
&& !this.isCurrentUserOwnMessage
&& this.message.actorType === ATTENDEE.ACTOR_TYPE.USERS
&& this.$store.getters.isActorUser()
&& !this.isCurrentGuest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: need to unify that, we have a lot of different checks in different places for that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also follow-up: we are checking it now based on actorType:

	const isActorUser = computed(() => actorType.value === ATTENDEE.ACTOR_TYPE.USERS)
	const isActorGuest = computed(() => actorType.value === ATTENDEE.ACTOR_TYPE.GUESTS)

Because we set one of these in setCurrentUser() or setCurrentParticipant(). But actorType can be also 'emails' | 'bridged' | 'federated_users' | 'phones'

Correct way (what we actually want to check) in most places is if user logged in: userId !== null, right?

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works so far =)

&& !this.isCurrentUserOwnMessage
&& this.message.actorType === ATTENDEE.ACTOR_TYPE.USERS
&& this.$store.getters.isActorUser()
&& !this.isCurrentGuest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also follow-up: we are checking it now based on actorType:

	const isActorUser = computed(() => actorType.value === ATTENDEE.ACTOR_TYPE.USERS)
	const isActorGuest = computed(() => actorType.value === ATTENDEE.ACTOR_TYPE.GUESTS)

Because we set one of these in setCurrentUser() or setCurrentParticipant(). But actorType can be also 'emails' | 'bridged' | 'federated_users' | 'phones'

Correct way (what we actually want to check) in most places is if user logged in: userId !== null, right?

@DorraJaouad DorraJaouad force-pushed the chore/noid/migrate-actor-store branch 2 times, most recently from 920ba3a to 9e9d82b Compare June 11, 2025 13:49
@DorraJaouad DorraJaouad force-pushed the chore/noid/migrate-actor-store branch from 9e9d82b to ba139c8 Compare June 11, 2025 14:38
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, minor comments

@DorraJaouad DorraJaouad force-pushed the chore/noid/migrate-actor-store branch from 8a299b0 to 0709f74 Compare June 11, 2025 19:24
@DorraJaouad DorraJaouad marked this pull request as ready for review June 11, 2025 19:24
@DorraJaouad DorraJaouad enabled auto-merge June 11, 2025 19:24
@DorraJaouad DorraJaouad merged commit 2a4341f into main Jun 11, 2025
54 checks passed
@DorraJaouad DorraJaouad deleted the chore/noid/migrate-actor-store branch June 11, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants