-
Notifications
You must be signed in to change notification settings - Fork 509
feat(threads): Allow to set thread title (frontend) #15584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
90de09e to
235f3ac
Compare
| <NcNoteCard v-if="showMentionEditHint" | ||
| type="warning" | ||
| :text="t('spreed', 'Adding a mention will only notify users who did not read the message.')" /> | ||
| <NcTextField |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is present, I suggest to make new message input longer in height.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the reason behind it. There is already a placeholder in place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visual reasons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe place the emoji picker in top corner? new-message-form__emoji-picker
|
@Antreesy Do you think we should show the title in bold and not hide it? It feels weird to have it not shown in message. I would tweak MessageBody to show the title too in different computed from the message text and also when editing, you will have title and message separately. |
0f11e39 to
b3a790f
Compare
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
b3a790f to
fd1266d
Compare
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist