Skip to content

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 25, 2025

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
action 2025-07-29_11h49_17 2025-07-29_11h49_51
input image image
file share image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team

@Antreesy Antreesy added this to the 🪺 Next Major (32) milestone Jul 25, 2025
@Antreesy Antreesy self-assigned this Jul 25, 2025
@Antreesy Antreesy changed the title feat(threads): Allow threads only while posting with a title feat(threads): Allow to set thread title (frontend) Jul 29, 2025
@Antreesy Antreesy force-pushed the feat/9680/thread-title branch 4 times, most recently from 90de09e to 235f3ac Compare July 30, 2025 15:23
@Antreesy Antreesy marked this pull request as ready for review July 30, 2025 15:23
@Antreesy Antreesy requested a review from DorraJaouad July 30, 2025 15:24
<NcNoteCard v-if="showMentionEditHint"
type="warning"
:text="t('spreed', 'Adding a mention will only notify users who did not read the message.')" />
<NcTextField
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is present, I suggest to make new message input longer in height.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the reason behind it. There is already a placeholder in place

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual reasons

Copy link
Contributor

@DorraJaouad DorraJaouad Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe place the emoji picker in top corner? new-message-form__emoji-picker

@DorraJaouad
Copy link
Contributor

@Antreesy Do you think we should show the title in bold and not hide it? It feels weird to have it not shown in message.

I would tweak MessageBody to show the title too in different computed from the message text and also when editing, you will have title and message separately.

@Antreesy Antreesy force-pushed the feat/9680/thread-title branch from 0f11e39 to b3a790f Compare July 31, 2025 10:39
@Antreesy Antreesy force-pushed the feat/9680/thread-title branch from b3a790f to fd1266d Compare July 31, 2025 12:19
@Antreesy Antreesy merged commit d77e6f4 into main Jul 31, 2025
53 checks passed
@Antreesy Antreesy deleted the feat/9680/thread-title branch July 31, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants